Skip to content

boards: renesas: update board doc for ek_ra8d1 #87503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 9, 2025
Merged

boards: renesas: update board doc for ek_ra8d1 #87503

merged 3 commits into from
Apr 9, 2025

Conversation

thanhthe23
Copy link
Contributor

@thanhthe23 thanhthe23 commented Mar 22, 2025 •
edited
Loading

Correct doc formatting of

  • boards/shields/rtk7eka6m3b00001bu
  • boards/shields/rtkmipilcdb00000be

Update information of hardware configuration for display shield using on ek_ra8d1

@github-actions GitHub Actions
Copy link

Hello @thanhthe23, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@thanhthe23 thanhthe23 changed the title Ek_ra8d1_display_shield_doc_update boards: renesas: update board doc for ek_ra8m1 Mar 22, 2025
@thanhthe23 thanhthe23 changed the title boards: renesas: update board doc for ek_ra8m1 boards: renesas: update board doc for ek_ra8d1 Mar 22, 2025
@thanhthe23 thanhthe23 marked this pull request as ready for review March 22, 2025 10:52
@zephyrbot zephyrbot added area: Shields Shields (add-on boards) platform: Renesas RA Renesas Electronics Corporation, RA labels Mar 22, 2025
kartben
kartben requested changes Mar 26, 2025
View reviewed changes
boards/renesas/ek_ra8d1/doc/index.rst Outdated
Comment on lines 100 to 101
| SW1-1 PMOD1 | SW1-2 TRACE | SW1-3 CAMERA | SW1-4 ETHA | SW1-5 ETHB | SW1-6 GLCD | SW1-7 SDRAM | SW1-8 I3C |
+-------------+-------------+--------------+------------+------------+------------+-------------+-----------+
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks broken?

soburi
soburi previously requested changes Apr 2, 2025
View reviewed changes
@thanhthe23 thanhthe23 force-pushed the ek_ra8d1_display_shield_doc_update branch from b8a7a66 to ef84058 Compare April 3, 2025 14:35
@thanhthe23
boards: shields: rtk7eka6m3b00001bu: update shield doc
8ba70df 
Correct doc formatting
Remove platform specific hardware configuration

Signed-off-by: The.Thanh Nguyen <[email protected]>
@thanhthe23
boards: shields: rtkmipilcdb00000be: update shield doc
54de56e 
Correct doc formatting
Remove platform specific hardware configuration

Signed-off-by: The.Thanh Nguyen <[email protected]>
@thanhthe23 thanhthe23 force-pushed the ek_ra8d1_display_shield_doc_update branch from ef84058 to f58161d Compare April 3, 2025 14:44
kartben
kartben previously approved these changes Apr 7, 2025
View reviewed changes
@thanhthe23
boards: renesas: update ek_ra8d1 board doc
0ddfda8 
Add hardware configuration when using with display shield

Signed-off-by: The.Thanh Nguyen <[email protected]>
@thanhthe23 thanhthe23 force-pushed the ek_ra8d1_display_shield_doc_update branch from f58161d to 0ddfda8 Compare April 7, 2025 11:18
@github-actions github-actions bot requested a review from thenguyenyf April 7, 2025 11:19
@thanhthe23 thanhthe23 requested review from kartben and soburi April 7, 2025 13:52
@kartben kartben dismissed soburi’s stale review April 9, 2025 04:57

In the future please don't block PRs for things that CI will catch anyway since this causes PR to be blocked unnecessarily :)

@kartben kartben merged commit 4f2dc5f into zephyrproject-rtos:main Apr 9, 2025
19 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2025

Hi @thanhthe23!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

thaoluonguw
thaoluonguw reviewed Apr 9, 2025
View reviewed changes
boards/renesas/ek_ra8d1/doc/index.rst
Comment on lines +105 to +106
- For using the Parallel Graphics Expansion Port (J57) with the Graphics Expansion Board supplied as part of the kit,
please set switch SW1 as following configuration:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, there is mistake in previous information. Please help us correct too:
Correct one should be:
"For using the Parallel Graphics Expansion Port (J57) with the Graphics Expansion Board supplied as part of EK-RA6M3G kit, please set switch SW1 as following configuration:"
Although setting for SW1 is same with MIPI shield, I am Okie with this structure for easy to refer.
Thank you.

boards/shields/rtk7eka6m3b00001bu/doc/index.rst
@@ -36,19 +36,6 @@ Supported Renesas RA boards: EK-RA8D1
- 1 x RA Board
- 1 x Micro USB cable
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It requires a converter board or wiring. We will update later in other PR.

@thaoluonguw
Copy link
Collaborator

Hello @thanhthe23 , I am sorry for late review. We will create another PR for remain pointing out. Thank you so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thaoluonguw thaoluonguw thaoluonguw left review comments

@kartben kartben kartben approved these changes

@soburi soburi soburi approved these changes

@thenguyenyf thenguyenyf thenguyenyf approved these changes

@duynguyenxa duynguyenxa duynguyenxa approved these changes

@avisconti avisconti Awaiting requested review from avisconti

@erwango erwango Awaiting requested review from erwango

@jfischer-no jfischer-no Awaiting requested review from jfischer-no

@KhiemNguyenT KhiemNguyenT Awaiting requested review from KhiemNguyenT

Assignees

@kartben kartben

Labels
area: Shields Shields (add-on boards) platform: Renesas RA Renesas Electronics Corporation, RA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@thanhthe23 @thaoluonguw @kartben @soburi @thenguyenyf @duynguyenxa @zephyrbot